Replace () => arrow lambdas with function () for Mocha
#3631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
added
Issue-Enhancement
andyleejordan
changed the title
() => arrow lambds with function () for MochaJS() => arrow lambds with function () for Mocha
|
Oops:
Will have to fix the lint rule because this is Mocha's recommended practice (and necessary for the next step of proper parameterization). |
The former lexically binds `this` and so prevents access to Mocha's test context, hence its documentation advises the use of `function ()` instead. This allows access to the context for skipping, parameterization, etc. Note that this requires disabling the TSLint rule which disagrees with Mocha's recommendation.
andyleejordan
force-pushed
the
andschwa/mocha
branch
from
c2c7031 to
35b1fa5
Compare
andyleejordan
changed the title
() => arrow lambds with function () for Mocha() => arrow lambdas with function () for Mocha
rjmholt
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former lexically binds
thisand so prevents access to Mocha's test context, hence its documentation advises the use offunction ()instead. This allows access to the context for skipping, parameterization, etc.Part of #3596.