Skip to content

Document the trace server setting is valid (despite Code's warning) #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Sep 7, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Sep 4, 2021

PR Summary

I propose this additional note as VSCode does not recognize the "powershell editor services.trace.server":"verbose" setting. The result is: Unknown Configuration Setting, which leads to unnecessary consternation.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests NA
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

I propose this additional note as VSCode does not recognize this setting. The result is: 'Unknown Configuration Setting'.
#3543 (comment)
@andyleejordan andyleejordan added Area-Documentation Issue-Enhancement A feature request (enhancement). labels Sep 7, 2021
@andyleejordan andyleejordan changed the title additional note about the PowerShell Editor Services setting Document the trace server setting is valid (despite Code's warning) Sep 7, 2021
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!

@andyleejordan andyleejordan merged commit a836475 into PowerShell:master Sep 7, 2021
@ghost ghost deleted the patch-1 branch September 7, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Documentation Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant