Update build and task configurations #3518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These existed to invoke tasks in the associated PowerShellEditorServices folder; however, the `Build` task was previously fixed to automatically build and copy that dependency when needed. Furthermore, the existing VS Code tasks meant that for developers' ease-of-use we could already clean, build, and test that dependency. Finally, CI did not depend on the `All` section of these for testing, as we have separate CI/CD pipelines for each project, so these were redundant and confusing.
andyleejordan
commented
Aug 23, 2021
| @@ -459,7 +459,7 @@ | |||
| "type": "PowerShell", | |||
| "request": "launch", | |||
| "script": "^\"\\${file}\"", | |||
| "cwd": "^\"\\${file}\"" | |||
| "cwd": "^\"\\${workspaceFolder}\"" | |||
There was a problem hiding this comment.
@rkeithhill Do you know why this was file before? It seemed quite wrong to me, as the thing is asking for a directory, and our other task (below) was given workspaceFolder too.
There was a problem hiding this comment.
I found my answer at long last...
vscode-powershell/src/features/DebugSession.ts
Lines 304 to 306 in 3dc11c1
andyleejordan
commented
Aug 23, 2021
| @@ -106,7 +100,7 @@ task UpdateReadme -If { $script:IsPreviewExtension } { | |||
| } | |||
| } | |||
|
|
|||
| task Package UpdateReadme, { | |||
| task Package UpdateReadme, Build, { | |||
There was a problem hiding this comment.
Annoying dependency bug if you've cleaned and then want to package, it should just build.
andyleejordan
commented
Aug 23, 2021
| } | ||
| }, | ||
| { | ||
| "name": "PowerShell Launch Current File", |
There was a problem hiding this comment.
I'm using this a lot when testing, high time to put it in the project's config.
rjmholt
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small mostly developer oriented fixes.