Improve PowerShell session management, status reporting, and logging #350
Conversation
|
This is a pretty big change so I'll give @rkeithhill a chance to take a look before merging :) |
| if (logLevel >= this.MinimumLogLevel) { | ||
| // TODO: Add timestamp | ||
| this.logChannel.appendLine(message); | ||
| fs.appendFile(this.logFilePath, message + "\r\n"); |
There was a problem hiding this comment.
Should these line endings change to \n for Linux and macOS?
There was a problem hiding this comment.
Hmm, yeah, good point. In fact, I need to verify that this all works correctly on Linux/macOS anyway, so I'll change that before I merge.
This change introduces a pretty large refactoring of the existing extension code to improve the overall user experience. Here is a summary of the changes: - The PowerShell session is now restartable at any time while VS Code is running without restarting the whole VS Code window. This is exposed through the "Restart PowerShell Session" command. - A new status indicator has been added to the status bar which lets the user know when the language server is starting, running, or in an error state. - Logs for the extension are now written to an output channel in the UI allowing the user to show them at any time with the "Show PowerShell Extension Logs" command. - Any failure to load the PowerShell session will show an error message to the user and give them the opportunity to show the extension logs. - If the PowerShell process ends unexpectedly at any time, the user will be shown a prompt to restart the session. - Logs for each session are now written out to individual log folders instead of creating them all in the same folder. Resolves #281.
daviwil
force-pushed
the
daviwil/extension-refactor
branch
from
a4b1257 to
636cb90
Compare
|
@rkeithhill Quick question: which nomenclature do you think is more appropriate for PowerShell folks, 32-bit/64-bit or x86/x64? The former is clearer but the latter seems to be used for the Windows PowerShell shortcuts (x86 at least). |
|
I'd go with the latter for the reason you mention - names of shortcuts and what shows up in the window title. |
This change completes the session management menu which allows the user to easily switch or restart their PowerShell session. It also improves log creation across sessions.
daviwil
force-pushed
the
daviwil/extension-refactor
branch
from
636cb90 to
5f60fc3
Compare
| @@ -32,16 +32,17 @@ | |||
| "vscode-languageclient": "1.3.1" | |||
There was a problem hiding this comment.
Is it missing "vscode-jsonrpc" ? I cannot compile it without adding "vscode-jsonrpc" as a dependency.
There was a problem hiding this comment.
Hmm, that shouldn't be the case, I'll come by your office later to take a look.
This change introduces a pretty large refactoring of the existing extension code to improve the overall user experience. Here is a summary of the changes:
Resolves #281.