Skip to content

Explicitly disable extension for untrusted workspaces #3416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

andyleejordan
Copy link
Member

This extension can read and execute code from a workspace folder, therefore it
is a potential security risk to run the extension in an untrusted workspace.
Until we can put more effort into partial support of safe features, we will
explicitly disable this extension when the workspace is untrusted.

Resolves #3334.

This extension can read and execute code from a workspace folder, therefore it
is a potential security risk to run the extension in an untrusted workspace.
Until we can put more effort into partial support of safe features, we will
explicitly disable this extension when the workspace is untrusted.
@andyleejordan andyleejordan requested a review from rjmholt June 15, 2021 22:26
@ghost ghost added Area-Workspaces Issue-Enhancement A feature request (enhancement). labels Jun 15, 2021
@andyleejordan andyleejordan enabled auto-merge (squash) June 15, 2021 23:14
@andyleejordan andyleejordan merged commit b20f9b4 into master Jun 15, 2021
@andyleejordan andyleejordan deleted the andschwa/workspace-trust branch June 15, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Workspaces Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Workspace Trust
2 participants