Change OS-architecture check to work with other locales #3392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld work on most languages
|
Solves issue #3390 |
rjmholt
changed the title
rjmholt
approved these changes
Jun 2, 2021
|
It does strike me that we should assume 64-bit and test for 32-bit, but that's a bigger change and this one should work in most cases so I'm happy to take this one as is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3390
PR Summary
Matching was done with literal equality check:
-eq '64-bit'. This has been changed to Regex:-match '64'. This so it won't matter what the language of the OS is. For example this will match '64-bittinen', '64-bëssen'PR Checklist
WIP:to the beginning of the title and remove the prefix when the PR is ready