Skip to content

Remove the rest of the experimental Notebook API #3212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,4 @@ npm-debug.log
.vscode-test/
*.DS_Store
test-results.xml
vscode.d.ts
test/.vscode/settings.json
1 change: 0 additions & 1 deletion .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
"runtimeExecutable": "${execPath}",
"args": [
"--disable-extensions",
"--enable-proposed-api",
"ms-vscode.powershell-preview",
"--extensionDevelopmentPath=${workspaceFolder}",
"--extensionTestsPath=${workspaceFolder}/out/test/testRunner.js",
Expand Down
66 changes: 1 addition & 65 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

75 changes: 2 additions & 73 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,7 @@
"onCommand:PowerShell.RegisterExternalExtension",
"onCommand:PowerShell.UnregisterExternalExtension",
"onCommand:PowerShell.GetPowerShellVersionDetails",
"onView:PowerShellCommands",
"onNotebook:PowerShellNotebookModeDefault",
"onNotebookEditor:PowerShellNotebookModeDefault",
"onNotebook:PowerShellNotebookModeOption",
"onNotebookEditor:PowerShellNotebookModeOption"
"onView:PowerShellCommands"
],
"dependencies": {
"node-fetch": "~2.6.1",
Expand Down Expand Up @@ -77,7 +73,6 @@
"tslint": "~6.1.3",
"typescript": "~4.1.5",
"vsce": "~1.85.0",
"vscode-dts": "~0.3.1",
"vscode-test": "~1.4.0"
},
"extensionDependencies": [
Expand All @@ -86,8 +81,7 @@
"scripts": {
"compile": "tsc -v && tsc -p ./ && tslint -p ./",
"compile-watch": "tsc -watch -p ./",
"test": "node ./out/test/runTests.js",
"download-api": "vscode-dts dev"
"test": "node ./out/test/runTests.js"
},
"contributes": {
"breakpoints": [
Expand All @@ -113,29 +107,6 @@
}
]
},
"notebookProvider": [
{
"viewType": "PowerShellNotebookModeDefault",
"displayName": "Powershell Notebook",
"selector": [
{
"filenamePattern": "*.[Nn]otebook.ps1"
}
],
"priority": "default"
},
{
"viewType": "PowerShellNotebookModeOption",
"displayName": "Powershell Notebook",
"selector": [
{
"excludeFileNamePattern": "*.Notebook.ps1",
"filenamePattern": "*.ps1"
}
],
"priority": "option"
}
],
"keybindings": [
{
"command": "PowerShell.ShowHelp",
Expand Down Expand Up @@ -231,24 +202,6 @@
"dark": "resources/dark/play.svg"
}
},
{
"command": "PowerShell.EnableNotebookMode",
"title": "(Preview) Enable Notebook Mode",
"category": "PowerShell",
"icon": {
"light": "resources/light/book.svg",
"dark": "resources/dark/book.svg"
}
},
{
"command": "PowerShell.DisableNotebookMode",
"title": "(Preview) Disable Notebook Mode",
"category": "PowerShell",
"icon": {
"light": "resources/light/file-code.svg",
"dark": "resources/dark/file-code.svg"
}
},
{
"command": "PowerShell.RestartSession",
"title": "Restart Current Session",
Expand Down Expand Up @@ -424,16 +377,6 @@
"when": "editorLangId == powershell && config.powershell.buttons.showRunButtons",
"command": "PowerShell.RunSelection",
"group": "navigation@101"
},
{
"when": "editorLangId == powershell && config.powershell.notebooks.showToggleButton",
"command": "PowerShell.EnableNotebookMode",
"group": "navigation@102"
},
{
"when": "resourceLangId == powershell && notebookEditorFocused",
"command": "PowerShell.DisableNotebookMode",
"group": "navigation@102"
}
],
"editor/title/context": [
Expand Down Expand Up @@ -949,20 +892,6 @@
"type": "boolean",
"default": false,
"description": "Show buttons in the editor titlebar for moving the panel around."
},
"powershell.notebooks.showToggleButton": {
"type": "boolean",
"default": false,
"description": "Controls whether we show or hide the buttons to toggle Notebook mode in the top right."
},
"powershell.notebooks.saveMarkdownCellsAs": {
"type": "string",
"enum": [
"BlockComment",
"LineComment"
],
"default": "BlockComment",
"description": "Controls what new markdown cells in Notebook Mode get saved as in the PowerShell file."
}
}
},
Expand Down
3 changes: 0 additions & 3 deletions resources/dark/book.svg

This file was deleted.

3 changes: 0 additions & 3 deletions resources/dark/file-code.svg

This file was deleted.

3 changes: 0 additions & 3 deletions resources/light/book.svg

This file was deleted.

3 changes: 0 additions & 3 deletions resources/light/file-code.svg

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion test/features/testNotebookFiles/onlyCode.ps1

This file was deleted.

3 changes: 0 additions & 3 deletions test/features/testNotebookFiles/onlyMarkdown.ps1

This file was deleted.

2 changes: 0 additions & 2 deletions test/features/testNotebookFiles/simple.Notebook.ps1

This file was deleted.

11 changes: 0 additions & 11 deletions test/features/testNotebookFiles/simpleBlockComments.ps1

This file was deleted.

7 changes: 0 additions & 7 deletions test/features/testNotebookFiles/simpleLineComments.ps1

This file was deleted.

9 changes: 0 additions & 9 deletions test/features/testNotebookFiles/simpleMixedComments.ps1

This file was deleted.