Skip to content

Update @types/vscode and StatusBarItem implementation #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2021

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Feb 11, 2021

This requires updating the StatusBarItem implementation, but moreover,
raises the lowest supported version of VS Code.

Replaces #3174.

@andyleejordan
Copy link
Member Author

@rjmholt How do we usually handle raising the minimum supported version of VS Code itself? IIRC, you've said we generally just support the latest and latest - 1 versions, which means this update shouldn't be in the next stable release #3178, despite seeming small.

@andyleejordan andyleejordan marked this pull request as ready for review February 11, 2021 22:34
@rjmholt
Copy link
Contributor

rjmholt commented Feb 12, 2021

So I talked this through with @TylerLeonhardt (since he knows a fair amount about VSCode and its API) and we should use the minimum types version we support.

By not upgrading we trust VSCode not to make a breaking change in its latest API, but we can generally trust that.

@andyleejordan
Copy link
Member Author

Perhaps there's a way to get Dependabot to ignore updates to @types/vscode (and so correspondingly vscode itself).

@TylerLeonhardt
Copy link
Member

If you comment this in the dependabot PR, it will ignore it for the future. I thought I already did that for that dependency but maybe dependabot eventually forgets or maybe I forgot.

@dependabot ignore this dependency

@andyleejordan
Copy link
Member Author

@TylerLeonhardt I just saw that lol, I'm really like dependabot so far!

@andyleejordan andyleejordan marked this pull request as draft February 16, 2021 19:31
@andyleejordan
Copy link
Member Author

Converted to draft until the day we can update this.

@andyleejordan
Copy link
Member Author

VS Code is at 1.55.0 now, think we can revisit merging this? @rjmholt

This requires updating the `StatusBarItem` implementation, but moreover,
raises the lowest supported version of VS Code.
@andyleejordan andyleejordan force-pushed the andschwa/types-vscode branch from 63c94f0 to 24ddfdc Compare May 20, 2021 19:52
@andyleejordan andyleejordan marked this pull request as ready for review May 20, 2021 19:52
@andyleejordan
Copy link
Member Author

@rjmholt, I verified with @Charles-Gagnon that Azure Data Studio now supports at minimum 1.53.0, so we should be good to go now!

@andyleejordan andyleejordan merged commit 233fb60 into master May 20, 2021
@andyleejordan andyleejordan deleted the andschwa/types-vscode branch May 20, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants