-
Notifications
You must be signed in to change notification settings - Fork 510
Update @types/vscode and StatusBarItem
implementation
#3179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4fd4a25
to
63c94f0
Compare
So I talked this through with @TylerLeonhardt (since he knows a fair amount about VSCode and its API) and we should use the minimum types version we support. By not upgrading we trust VSCode not to make a breaking change in its latest API, but we can generally trust that. |
Perhaps there's a way to get Dependabot to ignore updates to @types/vscode (and so correspondingly vscode itself). |
If you comment this in the dependabot PR, it will ignore it for the future. I thought I already did that for that dependency but maybe dependabot eventually forgets or maybe I forgot.
|
@TylerLeonhardt I just saw that lol, I'm really like dependabot so far! |
Converted to draft until the day we can update this. |
VS Code is at 1.55.0 now, think we can revisit merging this? @rjmholt |
This requires updating the `StatusBarItem` implementation, but moreover, raises the lowest supported version of VS Code.
63c94f0
to
24ddfdc
Compare
@rjmholt, I verified with @Charles-Gagnon that Azure Data Studio now supports at minimum 1.53.0, so we should be good to go now! |
This requires updating the
StatusBarItem
implementation, but moreover,raises the lowest supported version of VS Code.
Replaces #3174.