Skip to content

Remove hardcoded output format #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

TylerLeonhardt
Copy link
Member

PR Summary

Pester renamed these so I'm removing this so the default value is used which is NUnit either way. Eventually, we should allow folks to pass in the output format they care about but I think I'm the only one that will care.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@rjmholt
Copy link
Contributor

rjmholt commented Dec 11, 2020

Pester renamed these so I'm removing this so the default value is used which is NUnit either way

What version did Pester remove these in? Is there a chance this could affect older Pester versions?

@TylerLeonhardt
Copy link
Member Author

TylerLeonhardt commented Dec 11, 2020

@rjmholt it apparently changed in 5.1. It went from NUnit2.5 -> NUnitXml

@TylerLeonhardt TylerLeonhardt merged commit 6654510 into master Dec 11, 2020
@TylerLeonhardt TylerLeonhardt deleted the remove-hardcoded-output-format branch December 11, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants