Add coloring for $ and wordSepartors #2702
Conversation
ghost
added
Area-Configuration
Area-Documentation
Issue-Enhancement
src/features/ISECompatibility.ts
Outdated
| @@ -24,6 +24,7 @@ export class ISECompatibilityFeature implements IFeature { | |||
| { path: "powershell.integratedConsole", name: "focusConsoleOnExecute", value: false }, | |||
| { path: "files", name: "defaultLanguage", value: "powershell" }, | |||
| { path: "workbench", name: "colorTheme", value: "PowerShell ISE" }, | |||
| { path: "editor", name: "wordSeparators", value: "`~!@#%^&*()-=+[{]}\\|;:'\",.<>/?" } | |||
There was a problem hiding this comment.
Did this value for the word separators come from anywhere in particular? I'm wondering about the following: ~, @, #, ^, *, -, \, :.
It depends on the context in which I think of where we're defining "words" too. In expression mode, * and - are word separators, but in command mode they're not. I suspect we should prefer expression mode, but want to raise it in any case
There was a problem hiding this comment.
It's the default minus the $ - I originally said this here:
#2546 (comment)
Not perfect... but better.
There was a problem hiding this comment.
Right, i used the example Tyler mentioned in the comment.
Is there a better implementation?
There was a problem hiding this comment.
I'm happy with better. We can improve it in future as needed
|
@MJECloud looks like there's a conflict now with a PR that just went in. Can you rebase or resolve the conflict? |
|
Resolved the conflict. |
|
Thanks for doing that! |
PR Summary
Adding scopes in the theme to make the $ orange aswell.
Also adding wordSepartors to ISE Mode
Fixes #2546
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready