Clean up WaitForSessionFile logic and support increasing timeout with warning #2653
Conversation
package.json
Outdated
| @@ -761,6 +761,11 @@ | |||
| "default": null, | |||
| "description": "An array of strings that enable experimental features in the PowerShell extension." | |||
| }, | |||
| "powershell.developer.waitForSessionFileNumOfTries": { | |||
There was a problem hiding this comment.
As a setting I think it would make more sense to expose a timeout and then in the implementation just retry until the total exceeds the timeout
There was a problem hiding this comment.
I like that. Perhaps powershell.developer.sessionStartupTimeout?
src/process.ts
Outdated
| return reject(error); | ||
| } | ||
| // This is used to warn the user that the extension is taking longer than expected to startup. | ||
| const warnUserThreshold = numOfTries / 2; |
There was a problem hiding this comment.
For the warning, I'd imagine our standard expectation for startup time is a constant, like 30 seconds, rather than parameterised by the setting
| return new Promise(resolve => setTimeout(resolve, ms)); | ||
| } | ||
|
|
||
| private async waitForSessionFile(): Promise<utils.IEditorServicesSessionDetails> { |
There was a problem hiding this comment.
Thank you! We've been using async/await in our Electron/Angular app code base and vastly prefer it to dealing with Promises directly. :-)
|
Moved to seconds in the timeout, also changed the warning to call out "privilege enforcement software" as that seems to be the culprit in the issue. |
PR Summary
fixes #2526
This does 3 things:
powershell.developer.waitForSessionFileNumOfTriesto modify the 120 valueNote: I needed to move this function from utils.ts into process.ts because utils.ts is also used in debugAdapter.ts which can't use the
vscodenode_module.PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready