-
Notifications
You must be signed in to change notification settings - Fork 510
Display preview state and version info in PSIC startup banner #2644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display preview state and version info in PSIC startup banner #2644
Conversation
Question - I did not adjust the leading whitespace for the additional text. It occurs to me know that maybe that leading whitespace is to make the banner "somewhat" centered. If that was the intent, should I "reduce" the amount of whitespace for the extra characters? |
I think it would be a good idea to adjust the whitespace a bit. We had some complaints in the past that it's too far to the right anyway... |
RE adjusting whitespace. Which of these four do you like? 1 is the original. 2 has four spaces removed from leading whitespace. 3 has no leading whitespace. 4 has no leading whitespace and gets rid of one newline above and one newline below (still leaving one newline above and below). One more, make this #5 (no blank line before, one blank line after): |
I like number 2! |
Looking at some other repls: I prefer #5. But I'll go with whatever @TylerLeonhardt and @rjmholt want. |
I'm fine with number 5 too. If we get rid of all the whitespace - no one can complain that there's too much :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
PR Summary
Adds preview status and version info to the PSIC startup banner. The info comes from the extension (not PSES).
Fix #2643
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets.Please mark anything not applicable to this PR
NA
.WIP:
to the beginning of the title and remove the prefix when the PR is ready