Skip to content

Gracefully fail when trying to debug an Untitled file using Temp debugging #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Gracefully fail when trying to debug an Untitled file using Temp debugging #2458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions src/features/DebugSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,12 @@ export class DebugSessionFeature implements IFeature, DebugConfigurationProvider
const generateLaunchConfig = !config.request;

const settings = Settings.load();
let createNewIntegratedConsole = settings.debugging.createTemporaryIntegratedConsole;

// If the createTemporaryIntegratedConsole field is not specified in the launch config, set the field using
// the value from the corresponding setting. Otherwise, the launch config value overrides the setting.
if (config.createTemporaryIntegratedConsole === undefined) {
config.createTemporaryIntegratedConsole = settings.debugging.createTemporaryIntegratedConsole;
}

if (config.request === "attach") {
const platformDetails = getPlatformDetails();
Expand Down Expand Up @@ -192,7 +197,7 @@ export class DebugSessionFeature implements IFeature, DebugConfigurationProvider
? currentDocument.uri.toString()
: currentDocument.fileName;

if (settings.debugging.createTemporaryIntegratedConsole) {
if (config.createTemporaryIntegratedConsole) {
// For a folder-less workspace, vscode.workspace.rootPath will be undefined.
// PSES will convert that undefined to a reasonable working dir.
config.cwd =
Expand Down Expand Up @@ -222,6 +227,12 @@ export class DebugSessionFeature implements IFeature, DebugConfigurationProvider
}

if (currentDocument.isUntitled) {
if (config.createTemporaryIntegratedConsole) {
const msg = "Debugging Untitled files in a temporary console is currently not supported.";
vscode.window.showErrorMessage(msg);
return;
}

if (currentDocument.languageId === "powershell") {
if (!generateLaunchConfig) {
// Cover the case of existing launch.json but unsaved (Untitled) document.
Expand Down Expand Up @@ -264,14 +275,6 @@ export class DebugSessionFeature implements IFeature, DebugConfigurationProvider
if ((currentDocument !== undefined) && (config.cwd === "${file}")) {
config.cwd = currentDocument.fileName;
}

// If the createTemporaryIntegratedConsole field is not specified in the launch config, set the field using
// the value from the corresponding setting. Otherwise, the launch config value overrides the setting.
if (config.createTemporaryIntegratedConsole === undefined) {
config.createTemporaryIntegratedConsole = createNewIntegratedConsole;
} else {
createNewIntegratedConsole = config.createTemporaryIntegratedConsole;
}
}

// Prevent the Debug Console from opening
Expand All @@ -282,7 +285,7 @@ export class DebugSessionFeature implements IFeature, DebugConfigurationProvider

const sessionFilePath = utils.getDebugSessionFilePath();

if (createNewIntegratedConsole) {
if (config.createTemporaryIntegratedConsole) {
if (this.tempDebugProcess) {
this.tempDebugProcess.dispose();
}
Expand Down