Skip to content

Changes to enable dev host to launch. #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rkeithhill
Copy link
Contributor

@rkeithhill rkeithhill commented Jul 17, 2016

The changes are mainly to launch.json. The change to package.json is simply to reorder the scripts in the order they appear when you create a brand new extension. Yeah, a little OCD on my part.


This change is Reviewable

The changes are mainly to launch.json. The change to package.json is simply to reorder the scripts in the order they appear when you create a brand new extension.  Yeah, a little OCD on my part.
@rkeithhill
Copy link
Contributor Author

BTW there is a task in tasks.json called install but no corresponding script in package.json. There is a postinstall script. Should the tasks.json task be changed to postinstall?

@daviwil
Copy link
Contributor

daviwil commented Jul 18, 2016

Awesome! I haven't used that tasks.json file in a really long time so I forgot it was there :) Not sure about the install task, I think I grabbed this file from the VS Code team a long time ago so I don't even remember why it's there. We can take it out if you like.

@rkeithhill
Copy link
Contributor Author

In this case, maybe I'll just copy over the default tasks.json I got with the new extension I created with yo code. Let me do that tonight and push the change. I just wanted to make sure you weren't using the install task somehow.

@rkeithhill
Copy link
Contributor Author

rkeithhill commented Jul 19, 2016

Ah, the install task essentially runs npm install which populates the node_modules folder. OK, I think this PR is good to go then.

@rkeithhill rkeithhill merged commit 5d25d5f into PowerShell:master Jul 20, 2016
@rkeithhill rkeithhill deleted the rkeihthill/fix-devhost-launching branch July 20, 2016 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants