null check on activeTerminal to workaround vscode behavior #2141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Aug 16, 2019
| @@ -211,7 +211,8 @@ export class ConsoleFeature implements IFeature { | |||
| return; | |||
| } | |||
|
|
|||
| if (vscode.window.activeTerminal.name !== "PowerShell Integrated Console") { | |||
| if (vscode.window.activeTerminal && | |||
There was a problem hiding this comment.
Would this flow be better?
if (!activeTerminal && existingPsExtTerminal) {
// ShowSessionConsole
return;
}
if (!activeTerminal || activeTerminal !== "PowerShell Integrated Console") {
// Use runSelectedText
return;
}
// ShowSessionConsole
There was a problem hiding this comment.
@Tyriar I'm guessing from your snippet that existingPsExtTerminal would be used to determine if the PS extensions terminal is the "active"/"visible" terminal?
TylerLeonhardt
added a commit
to TylerLeonhardt/vscode-powershell
that referenced
this pull request
Sep 16, 2019
…l#2141) * null check on activeTerminal * newline for linting
TylerLeonhardt
added a commit
that referenced
this pull request
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
fixes #2137
For some reason, there is no active terminal until you click inside of the terminal so this protects against
vscode.window.activeTerminalnot being defined and will default to running the code in the PSICPR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready