Skip to content

add machine scope #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2019
Merged

add machine scope #2039

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d49b82
add machine scope
TylerLeonhardt Jun 20, 2019
94827a0
use a different setting for test and add user setting test
TylerLeonhardt Jun 25, 2019
48771b9
remove isExecutable and remove powershell.developer.powerShellExePath
TylerLeonhardt Jun 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"publisher": "ms-vscode",
"description": "(Preview) Develop PowerShell scripts in Visual Studio Code!",
"engines": {
"vscode": "^1.31.0"
"vscode": "^1.34.0"
},
"license": "SEE LICENSE IN LICENSE.txt",
"homepage": "https://github.com/PowerShell/vscode-powershell/blob/master/README.md",
Expand Down Expand Up @@ -545,12 +545,14 @@
"powershell.powerShellExePath": {
"type": "string",
"default": "",
"scope": "machine",
"isExecutable": true,
"description": "Specifies the full path to a PowerShell executable. Changes the installation of PowerShell used for language and debugging services."
},
"powershell.powerShellAdditionalExePaths": {
"type": "array",
"description": "Specifies an array of versionName / exePath pairs where exePath points to a non-standard install location for PowerShell and versionName can be used to reference this path with the powershell.powerShellDefaultVersion setting.",
"scope": "machine",
"isExecutable": true,
"uniqueItems": true,
"items": {
Expand Down Expand Up @@ -755,6 +757,7 @@
"powershell.developer.powerShellExePath": {
"type": "string",
"default": "",
"scope": "machine",
"isExecutable": true,
"description": "Deprecated. Please use the 'powershell.powerShellExePath' setting instead"
Copy link
Contributor

@rkeithhill rkeithhill Jun 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should get rid of this deprecated setting? It has been deprecated for a long time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}
Expand Down