Fix CustomViews by switching to WebViews #1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
approved these changes
Apr 24, 2019
TylerLeonhardt
force-pushed
the
fix-vscode-custom-views
branch
from
cae4fb4 to
0185ff6
Compare
|
Ok rewire is back but with it, comes 3 tests! |
|
Implementation has changed a bit - re-requested reviews |
rkeithhill
approved these changes
Apr 25, 2019
rjmholt
approved these changes
Apr 25, 2019
| // Setup types that are not exported. | ||
| const customViews = rewire("../../src/features/CustomViews"); | ||
| const htmlContentViewClass = customViews.__get__("HtmlContentView"); | ||
| const HtmlContentView: typeof htmlContentViewClass = htmlContentViewClass; |
There was a problem hiding this comment.
It's like reflection but much more convoluted lol
TylerLeonhardt
added a commit
to TylerLeonhardt/vscode-powershell
that referenced
this pull request
Apr 26, 2019
TylerLeonhardt
added a commit
to TylerLeonhardt/vscode-powershell
that referenced
this pull request
Apr 26, 2019
TylerLeonhardt
added
Backport-Complete
Area-Code Formatting
and removed
Backport-Legacy
Area-Code Formatting
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I'm going to try to see if I can add a test or two... but this fixes the *-VSCodeHtmlContentView cmdlets. You are still able to pass in stylesheets and javascript and it will inline them.
Then, in order to refresh your view to get any js or css updates, just run the
Show-VSCodeHtmlContentViewcmdlet again and your changes will be reflected.This also enables the persistent pages so if you click away from a view and come back, the state remains!
P.S. there seems to be some weird behavior when you close out of a view - we must not be cleaning up properly. This bug existed before this change... I might try to tackle it now.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready