Skip to content

Don't use -EncodedCommand on Windows #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Apr 2, 2019

PR Summary

Fixes #1831

Conditionally uses EncodedCommand for only non-Windows

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt TylerLeonhardt merged commit f9e13c6 into PowerShell:master Apr 2, 2019
@TylerLeonhardt TylerLeonhardt deleted the not-encoded-command-on-windows branch April 2, 2019 17:09
rjmholt pushed a commit to rjmholt/vscode-powershell that referenced this pull request Apr 10, 2019
rjmholt pushed a commit that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AV detection triggered by encoded string used to execute "Start-EditorServices.ps1"
3 participants