Skip to content

Prep for 2.0.0-preview.2 release #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Mar 25, 2019

I also snuck in a small change to the changelog script and fixes for the name to be lowercase.

Reminder: I'm reving the version to 2.0.1 in the package.json because the vscode marketplace does not accept semver and package.json does not except anything other than semver... that means we only have X.X.X at our disposal.

@@ -372,7 +372,7 @@ function Get-PowerShellExtensionChangeLog {
)

$vscodePowerShell = Get-ChangeLog -LastReleaseTag $LastReleaseTag -Token $Token -HasCherryPick:$HasCherryPick.IsPresent -RepoUri 'https://api.github.com/repos/PowerShell/vscode-powershell' -RepoName 'vscode-PowerShell'
Push-Location ../PowerShellEditorServices
Push-Location (Join-Path $PSScriptRoot .. .. PowerShellEditorServices)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to mark this script as #Requires -Version 6.0 since this Join-Path command won't work on <= v5.

CHANGELOG.md Outdated
* Support for [PSScriptAnalyzer 1.18](https://github.com/PowerShell/PSScriptAnalyzer/releases/tag/1.18.0) 📝
* The ability to debug any runspace in any process 🔎
* PSReadLine enabled by default on Windows 🎨
* (Bug fix!) You can open untitled workspaces again! 🐛☠️
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untitled "workspaces" or untitled documents?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workspaces is right here. It's often called an Untitled folder

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a question and a minor, optional suggestion.

@TylerLeonhardt TylerLeonhardt merged commit 3e59c98 into PowerShell:master Mar 26, 2019
@TylerLeonhardt TylerLeonhardt deleted the prep-2.0.0-preview.2-release branch March 26, 2019 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants