Skip to content

Backport PSSA 1.18.0 PRs #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bergmeister
Copy link
Contributor

PR Summary

Backport PR #1669, #1668 (which was no squash-merged!,hence the -m option) and #1687 (in the same order below):

git cherry-pick 4d73772071bde2fb1ab7eb5f85a5b9aba46d639e
git cherry-pick -m 1 3ea87d804c23922d9b1e7dfc03d1098fddb095fe
git cherry-pick 4c826b32817e298e56ccf37df8f339ab89385553

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

bergmeister and others added 3 commits March 20, 2019 22:19
…18: PipelineIndentationStyle (PowerShell#1669)

* Add powershell.codeformatting.pipelineIndentationStyle setting

* fix indentation
…18: WhitespaceInsideBrace and WhitespaceAroundPipe (PowerShell#1668)

* Add new settings: powershell.codeFormatting.WhitespaceInsideBrace and powershell.codeFormatting.WhitespaceAroundPipe

* fix whitespace

* Apply suggestions from code review
…: PSUseCorrectCasing (PowerShell#1687)

* Add powershell.codeformatting.pipelineIndentationStyle setting

* add UseCorrectCasing

* Revert "Add powershell.codeformatting.pipelineIndentationStyle setting"

This reverts commit a5487d7.

* fix comma

* Update package.json
@bergmeister bergmeister changed the base branch from master to legacy/1.x March 20, 2019 22:25
@bergmeister bergmeister marked this pull request as ready for review March 20, 2019 22:29
@bergmeister bergmeister reopened this Mar 20, 2019
@bergmeister
Copy link
Contributor Author

bergmeister commented Mar 20, 2019

Will close this PR as AppVeyor is confused (because originally I opened the PR against the wrong target branch and redirecting and close/open of the PR did not fix that. I re-opened this PR in #1805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants