Skip to content

Handle Pester Describe block strings with single quotes inside it #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2019
Merged

Handle Pester Describe block strings with single quotes inside it #1729

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b12035
Handle describe block strings with single quotes inside it.
bergmeister Jan 26, 2019
2a27168
fix replace call to handle expression with more than one single quote…
bergmeister Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/features/PesterTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ export class PesterTestsFeature implements IFeature {

if (describeBlockName) {
launchConfig.args.push("-TestName");
// Escape single quotes inside double quotes
if (describeBlockName.includes("'")) {
describeBlockName = describeBlockName.replace("'", "''");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're going to hate JS for this one...

https://davidwalsh.name/javascript-replace

You'll need to change the first "'" to a regex

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, the JS replace function bites me from time to time - coming from .NET where it works like it should. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks, I did not know that. I played around with it a bit in the console and it seems that replace basically breaks when there is more than 1 occurrence to be replaced. Yes, coming from a .Net world as well. Using .replace(/'/g, "''") seems to do the job

}
launchConfig.args.push(`'${describeBlockName}'`);
}

Expand Down