Skip to content

Handle name better #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 30, 2019
Merged

Conversation

TylerLeonhardt
Copy link
Member

PR Summary

Fixes #1721

For some reason, vscode has the storagePath set to null on untitled workspaces... this uses a different path as a fallback if that's not available. storagePath is the most accurate when it's set. extensionPath isn't fully accurate when running a local build of the extension because the extensionPath ends up being (on my machine):

~/Code/PowerShell/vscode/vscode-powershell

That said... hopefully I'll be able to address the initial limitation: microsoft/vscode#66515

Also, I added some tests and fixed up enabling the tests on non-windows.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@TylerLeonhardt
Copy link
Member Author

Looks like the test runner doesn't work on Linux... but it works on macOS so I kept macOS enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview extension not loading
2 participants