Skip to content

Fix language id #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2015
Merged

Fix language id #17

merged 1 commit into from
Nov 19, 2015

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Nov 19, 2015

The VS code built-in powershell extension has a language contribution that looks like that

        "languages": [{
            "id": "powershell",
            "extensions": [ ".ps1", ".psm1", ".psd1" ],
            "aliases": [ "PowerShell", "powershell", "ps", "ps1" ],
            "configuration": "./powershell.configuration.json"
        }],

The powershell extension however uses "id": "PowerShell"
This results in two 'Powershell' entries in the language selector drop down.

As long as we have the built-in powershell support, the powershell extension should use the same id, and ideally not contribute the language and grammar contribution but instead add a dependency on the built-in extension:

 "extensionDependencies": [
        "vscode.powershell"
    ],

This will make sure the built-in extension is loaded.

Please file an issue for any changes you'd like us to do the built-in contributes section (such as adding more file extension) or the grammar. Of course a pull request would even be easier.

@msftclas
Copy link

Hi @aeschli, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Martin Aeschlimann). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@daviwil
Copy link
Contributor

daviwil commented Nov 19, 2015

You are awesome, thank you! In the future I'll send pull requests for the basic in-box PS functionality. I'm happy to do things that way.

daviwil added a commit that referenced this pull request Nov 19, 2015
@daviwil daviwil merged commit 6691383 into PowerShell:master Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants