Skip to content

[Ignore] use pwsh available on path to support building from snap pwsh #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

TylerLeonhardt
Copy link
Member

snap pwsh doesn't get added to /usr/bin so lets just use the pwsh on the path. I think it's a reasonable assumption.

@TylerLeonhardt TylerLeonhardt changed the title use pwsh available on path to support building from snap pwsh [Ignore] use pwsh available on path to support building from snap pwsh Dec 8, 2018
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right to me. Do we have a solution for preview builds?

@TylerLeonhardt
Copy link
Member Author

I don't think so, unfortunately there doesn't seem to be a "if you can't find this executable, use this"... at least I haven't found one.

@TylerLeonhardt TylerLeonhardt merged commit fd8a5db into master Dec 12, 2018
@TylerLeonhardt TylerLeonhardt deleted the use-pwsh-path branch December 12, 2018 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants