always runs in active terminal #1619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
requested review from
rjmholt,
rkeithhill and
SeeminglyScience
|
cc @alexandair |
rkeithhill
reviewed
Nov 29, 2018
rjmholt
approved these changes
Nov 30, 2018
|
@TylerLeonhardt Thank you so much. It will make it much easier to use various shells. Azure Cloud Shell, I'm looking at you. :) It will work with multiple lines when a backtick is used as a continuation character, right? |
TylerLeonhardt
force-pushed
the
conditional-F8
branch
from
e79cf8a to
453ebe8
Compare
|
I seem to have found a potential bug in VSCode with this change... can't merge this in until it's sorted: |
TylerLeonhardt
changed the title
TylerLeonhardt
force-pushed
the
conditional-F8
branch
from
453ebe8 to
4c781fb
Compare
|
@TylerLeonhardt Excellent. |
TylerLeonhardt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
fixes #1607
Note: I decided against having this behavior to be configurable. The thought was that most people will only use the PowerShell Integrated Console.
In #1607 I brought up worry about people getting confused that their intellisense cache was not updating if they use pwsh instead of PSIC... I think perhaps this is a worry that does not exist and if it does and they open an issue, we can educate them.
Thoughts?
NOTE this relies on an engine update to 1.29 which is the current release. We probably don't want to merge this in until 1.30 is released1.30 has been released
NOTE I seem to have found a potential bug (microsoft/vscode#64390) in VSCode with this change... can't merge this in until it's sortedThe bug has been fixed. We can probably merge this in when 1.31.0 drops.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready