Restart Current Session in every session quick pick
#1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
requested review from
rkeithhill,
rjmholt and
SeeminglyScience
SeeminglyScience
approved these changes
Nov 23, 2018
rjmholt
reviewed
Nov 26, 2018
| const currentExePath = (this.powerShellExePath || "").toLowerCase(); | ||
| const availablePowerShellExes = | ||
| getAvailablePowerShellExes(this.platformDetails, this.sessionSettings); | ||
|
|
||
| let sessionText: string; |
There was a problem hiding this comment.
If this.sessionStatus is not SessionStatus.Running or SessionStatus.Failed, will this remain undefined? What will be shown in the menu?
If we're just branching on different values of an enum, maybe a switch block would be clearer?
There was a problem hiding this comment.
exhaustive switch statements FTW 👍 updated to a switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
fixes #1614
This does some reorganizing of the quick pick dialog for sessions. It makes sure the
Restart Current Sessioncommand is always available and only shows theSwitch to Xwhen a session is running.PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready