Add CodeAction support to show PSSA rule documentation #1600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corresponds to PSES PR: PowerShell/PowerShellEditorServices#789 Currently this points to the PSSA development branch. Maybe that should point to the master branch. Could be a setting I suppose but that seems like overkill.
|
There is more work to do here but I thought this would be a good start. For instance, the tslint extension is adding menu entries to the context menu in the Problems view. So you can right-click there and show documentation. With the PR you have to use the Code Fix icon in the source code. Still, it's a big improvement over not having it at all. :-) |
|
Here's an example of what this looks like: |
|
I think the development branch is OK to be used, especially since that is the branch against which PRs should be made (since I expect more people to do that now with this feature) |
rjmholt
approved these changes
Nov 6, 2018
TylerLeonhardt
approved these changes
Nov 7, 2018
|
Thanks. I'll merge this right after I get the PSES PR buttoned up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to PSES PR:
PowerShell/PowerShellEditorServices#789
Currently this points to the PSSA development branch. Maybe that should
point to the master branch. Could be a setting I suppose but that seems
like overkill.
PR Summary
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready