Skip to content

Make the Install-VSCode script work on *nix #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Nov 7, 2018
Merged

Make the Install-VSCode script work on *nix #1597

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2143d72
Make VSCode install script cross-plat
rjmholt Nov 1, 2018
0abacf6
Add WhatIf support to script
rjmholt Nov 1, 2018
867b231
Use consistent brace style
rjmholt Nov 1, 2018
40ad8f8
Support WhatIf properly
rjmholt Nov 1, 2018
3f8aca3
Fix BuildEdition cases
rjmholt Nov 1, 2018
629120b
Eliminate unneeded $info variable
rjmholt Nov 1, 2018
fae546f
Address @tylerl0706's feedback, add package manager installation
Nov 1, 2018
cb52739
Add SUSE support
Nov 1, 2018
56a033b
Optimize RPM installations
Nov 1, 2018
f065f06
Install extensions as user on *nix
Nov 1, 2018
ede509b
Fix string template bug
Nov 1, 2018
5a5dd9a
Improve non-sudo error
Nov 1, 2018
f44d870
Simplify sudo test logic
Nov 1, 2018
7219128
Increment script version
Nov 1, 2018
9cb2856
Add -y to package manager invocations
Nov 1, 2018
5a429af
Fix Windows IsOsX64 call
rjmholt Nov 2, 2018
4936994
Only use Start-BitsTransfer in Windows PowerShell
rjmholt Nov 2, 2018
641aa43
Correct usage of WhatIf
Nov 5, 2018
1dc7b18
Update scripts/Install-VSCode.ps1
SeeminglyScience Nov 7, 2018
5ac4579
Improve WhatIf usage
rjmholt Nov 7, 2018
e7859d6
Fix paren error
rjmholt Nov 7, 2018
3a1ddf4
Fix paren error
rjmholt Nov 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions scripts/Install-VSCode.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,8 +449,6 @@ try {
$prevWhatIfPreference = $WhatIfPreference
$WhatIfPreference = $WhatIfPreference -or $WhatIf

$onWindows = $IsWindows -or $PSVersionTable.PSVersion.Major -lt 6

# Get information required for installation
$codePlatformInfo = Get-CodePlatformInformation -Bitness $Architecture -BuildEdition $BuildEdition

Expand All @@ -462,7 +460,7 @@ try {

$installerPath = [System.IO.Path]::Combine($tmpdir, $installerName)

if ($onWindows) {
if ($PSVersionTable.PSVersion.Major -lt 6) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not Core compatible huh?

Copy link
Contributor Author

@rjmholt rjmholt Nov 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BitsTransfer wasn't loading for me 😢

Save-WithBitsTransfer -FileUri $codePlatformInfo.FileUri -Destination $installerPath -AppName $codePlatformInfo.AppName
}
# We don't want to use RPM packages -- see the installation step below
Expand Down