Skip to content

[Ignore] Stop building the v2 branch in master #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Oct 8, 2018

PR Summary

The build for master is still downloading @SeeminglyScience's PSReadLine branch.

This gets rid of that, since that's now in the 2.0.0 branch.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt
Copy link
Member

How will this grab the PSES 2.0.0 branch?

@rjmholt
Copy link
Contributor Author

rjmholt commented Oct 9, 2018

AppVeyor builds the 2.0.0 branch -- master doesn't have a 2.0.0 build. Means the extension VSIX will have a different version, so they can be interchanged more easily in VSCode contexts.

@TylerLeonhardt
Copy link
Member

Ah. I see. The Appveyor.yml grabs the 2.0.0 build of PSES in the 2.0.0 branch. 👍

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt
Copy link
Contributor Author

rjmholt commented Oct 9, 2018

@rjmholt rjmholt merged commit b955202 into PowerShell:master Oct 9, 2018
@rjmholt rjmholt deleted the stop-building-v2-branch branch December 12, 2018 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants