Skip to content

(maint) Add tests to PR Checklist #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

glennsarti
Copy link
Contributor

PR Summary

While the project has only a handful of tests, it would be in the interest of
contributors to at least be prompted to think about adding tests for new
functionality. This commit updates the PR template and adds a testing checkbox.
Note that these are not mandatory and can even be marked as N/A when people
raise a PR.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

While the project has only a handful of tests, it would be in the interest of
contributors to at least be prompted to think about adding tests for new
functionality.  This commit updates the PR template and adds a testing checkbox.
Note that these are not mandatory and can even be marked as N/A when people
raise a PR.
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wholeheartedly agree!

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt TylerLeonhardt merged commit dfffdb9 into PowerShell:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants