Skip to content

Fix attribution error in changelog script, update my email #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/Get-PowerShellExtensionChangelog.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ $Script:powershell_team = @(

$Script:powershell_team_emails = @(
"[email protected]"
"rjmholt@gmail.com"
"rjmholt_msft@outlook.com"
)

# Very active contributors; keep their email-login mappings here to save a few queries to Github.
Expand Down Expand Up @@ -311,6 +311,7 @@ function Get-ChangeLog
$message = $commit.Subject
}

$userToThank = $null
if (-not ($commit.AuthorEmail.EndsWith("@microsoft.com") -or ($powershell_team -contains $commit.AuthorName) -or ($powershell_team_emails -contains $commit.AuthorEmail))) {
if ($Script:community_login_map.ContainsKey($commit.AuthorEmail)) {
$commit.AuthorGitHubLogin = $Script:community_login_map[$commit.AuthorEmail]
Expand Down