Change "Get Online Help" menu item label: remove Online.

package.json

@@ -60,7 +60,7 @@
   "contributes": {
     "keybindings": [
       {
-        "command": "PowerShell.OnlineHelp",
+        "command": "PowerShell.ShowHelp",
         "key": "ctrl+f1",
         "when": "editorTextFocus && editorLangId == 'powershell'"
       },
@@ -88,7 +88,16 @@
       },
       {
         "command": "PowerShell.OnlineHelp",
-        "title": "Get Online Help for Command",
+        "title": "Get Online Help for Command(Deprecated)",
+        "category": "PowerShell"
+      },
+      {
+        "command": "PowerShell.ShowHelp",
+        "title": "Get Help for Command",
+        "category": "PowerShell"
+      },{
+        "command": "PowerShell.ShowOnlineHelp",
+        "title": "Dummy command. Shouldn't be released...",
         "category": "PowerShell"
       },
       {
@@ -166,7 +175,7 @@
         },
         {
           "when": "editorLangId == powershell",
-          "command": "PowerShell.OnlineHelp",
+          "command": "PowerShell.ShowHelp",
           "group": "2_powershell"
         }
       ]

src/features/ShowHelp.ts

@@ -0,0 +1,74 @@
+/*---------------------------------------------------------
+ * Copyright (C) Microsoft Corporation. All rights reserved.
+ *--------------------------------------------------------*/
+
+import vscode = require("vscode");
+import { LanguageClient, NotificationType, RequestType } from "vscode-languageclient";
+import { IFeature } from "../feature";
+
+export const ShowOnlineHelpRequestType =
+    new RequestType<string, void, void, void>("powerShell/showOnlineHelp");
+    // I think we can take out the ShowOnlineHelpRequestType... I don't think we actually send it...
+export const ShowHelpRequestType =
+    new RequestType<string, void, void, void>("powerShell/showHelp");
+export class ShowHelpFeature implements IFeature {
+
+    private command: vscode.Disposable;
+    private deprecatedCommand: vscode.Disposable;
+    // TODO: Remove Dummy command before merge.
+    // Dummy command is used to test out the write-warning in PSES
+    // when you send powerShell/showOnlineHelp instead of powerShell/showHelp.
+    private dummyCommand: vscode.Disposable;
+    private languageClient: LanguageClient;
+
+    constructor() {
+        // TODO: Remove this before merge.
+        this.dummyCommand = vscode.commands.registerCommand("PowerShell.ShowOnlineHelp", () => {
+            if (this.languageClient === undefined) {
+                // TODO: Log error message
+                return;
+            }
+
+            const editor = vscode.window.activeTextEditor;
+
+            const selection = editor.selection;
+            const doc = editor.document;
+            const cwr = doc.getWordRangeAtPosition(selection.active);
+            const text = doc.getText(cwr);
+
+            this.languageClient.sendRequest(ShowOnlineHelpRequestType, text);
+        });
+        this.command = vscode.commands.registerCommand("PowerShell.ShowHelp", () => {
+            if (this.languageClient === undefined) {
+                // TODO: Log error message
+                return;
+            }
+
+            const editor = vscode.window.activeTextEditor;
+
+            const selection = editor.selection;
+            const doc = editor.document;
+            const cwr = doc.getWordRangeAtPosition(selection.active);
+            const text = doc.getText(cwr);
+
+            this.languageClient.sendRequest(ShowHelpRequestType, text);
+        });
+        this.deprecatedCommand = vscode.commands.registerCommand("PowerShell.OnlineHelp", () => {
+            const warnText = "PowerShell.OnlineHelp is being deprecated. Use PowerShell.ShowHelp instead.";
+            vscode.window.showWarningMessage(warnText);
+            vscode.commands.executeCommand("PowerShell.ShowHelp");
+        });
+    }
+
+    public dispose() {
+        this.command.dispose();
+        this.deprecatedCommand.dispose();
+        // TODO: Remove this dummyCommand too...
+        // Don't forget the one in package.json
+        this.dummyCommand.dispose();
+    }
+
+    public setLanguageClient(languageclient: LanguageClient) {
+        this.languageClient = languageclient;
+    }
+}

src/main.ts

@@ -27,7 +27,7 @@ import { OpenInISEFeature } from "./features/OpenInISE";
 import { PesterTestsFeature } from "./features/PesterTests";
 import { RemoteFilesFeature } from "./features/RemoteFiles";
 import { SelectPSSARulesFeature } from "./features/SelectPSSARules";
-import { ShowHelpFeature } from "./features/ShowOnlineHelp";
+import { ShowHelpFeature } from "./features/ShowHelp";
 import { Logger, LogLevel } from "./logging";
 import { SessionManager } from "./session";
 import Settings = require("./settings");