Skip to content

Increase connection timeout #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2018
Merged

Increase connection timeout #1485

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40c3f68
Increase connection timeout
Aug 15, 2018
e65f7e4
Fix silliness
Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ export function waitForSessionFile(sessionFilePath: string, callback: IWaitForSe
}
}

// Try once per second for 60 seconds, one full minute
innerTryFunc(60, 1000);
// Try once every 2 seconds for 120 seconds, two full minutes
innerTryFunc(120, 2000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this bump the max wait time to 4 mins? 2 * 120 secs. Maybe just use (120, 1000)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'm thinking it should be 60, 2000 maybe? Ideally this should be exponential backoff style perhaps?

}

export function readSessionFile(sessionFilePath: string): IEditorServicesSessionDetails {
Expand Down