Skip to content

prep for 1.8.2 release #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 26, 2018
Merged

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Jul 26, 2018

🎉

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to update tools/releaseBuild/Image/DockerFile ?

@rkeithhill
Copy link
Contributor

One of these days, someone should write a script to update all these version numbers. Ditto for PSES. :-)

@TylerLeonhardt
Copy link
Member Author

@rkeithhill very good catch - I think that's talked about a bit in #1425

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt
Copy link
Member Author

TylerLeonhardt commented Jul 26, 2018

We're in business... passing CI - required making our dependency versions rules more strict. There's something in vscode-langaugeclient v4.4 that breaks us because it depends on version 1.25 of the vscode engine.

We don't want to update the engine until VSCode 1.26 comes out.

Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt TylerLeonhardt merged commit a555ba5 into PowerShell:master Jul 26, 2018
@TylerLeonhardt TylerLeonhardt deleted the prep-for-1.8.2 branch July 26, 2018 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants