Skip to content

Scroll the terminal to bottom for F8 execution #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

rkeithhill
Copy link
Contributor

@rkeithhill rkeithhill commented Jul 8, 2018

PR Summary

Scrolls the terminal to the bottom after F8 execution of a line or the current selection in the active editor.

Partial fix #1257

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@rkeithhill rkeithhill requested a review from TylerLeonhardt July 8, 2018 19:56
@rkeithhill
Copy link
Contributor Author

Hmm, looks like we have some code folding provider tests that are failing.

@rkeithhill rkeithhill changed the title Scroll the terminal to bottom for F8 executionPartial fix #1257 Scroll the terminal to bottom for F8 execution Jul 8, 2018
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@TylerLeonhardt
Copy link
Member

Cc @glennsarti

Spoke to Keith about this offline... Looks like VSCode updated the vscode-textmate package that we depend on for code folding. Actually it's been updated quite drastically :(

check out this https://www.npmjs.com/package/vscode-textmate/v/3.3.3
vs this: https://www.npmjs.com/package/vscode-textmate

They removed the function that we rely on to load the grammar:

registry.loadGrammarFromPathSync

We'll have to figure out how to use the new API or use a different package...

Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rkeithhill rkeithhill closed this Jul 10, 2018
@rkeithhill rkeithhill reopened this Jul 10, 2018
@rkeithhill rkeithhill merged commit 2e12b8e into master Jul 10, 2018
@rkeithhill rkeithhill deleted the rkeithhill/scroll-to-bottom-on-f8 branch July 10, 2018 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jump to Bottom of Integrated Terminal When Running PowerShell
3 participants