Skip to content

Fix markdown syntax #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2018
Merged

Conversation

lipkau
Copy link
Contributor

@lipkau lipkau commented Jun 24, 2018

PR Summary

  • Added rule for markdown linter
    • this makes markdown linter ignore duplicate headers in the same document
  • Fixed styling of community snippets
    • have all indentation to look alike
    • have code of snippets to use \t

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

lipkau added 2 commits June 24, 2018 18:52
this makes markdown linter ignore duplicate headers in the same document
* have all indentation to look alike
* have code of snippets to use `\t`
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for cleaning this up!

],
"description": "Pester Test for Parameter"
}
"Pester for Mandatory Pester": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Pester for Mandatory Parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so, based on the prefix and h3.
But I didn't change any content to the snips, as they are not mine.
(#1297)

Let me know if it is desired to fix that with this PR. I don't mind

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that was just a typo from the original PR. Would you mind fixing it? Thanks.

@lipkau
Copy link
Contributor Author

lipkau commented Jun 25, 2018

@tylerl0706 : I didn't do the .json with the snips for the module. Should I?

@TylerLeonhardt
Copy link
Member

@lipkau if you can, that'd be great. Otherwise, it's ok

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lipkau
Copy link
Contributor Author

lipkau commented Jun 25, 2018

Fixed the .json as well (although it had a lot less to fix)

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@TylerLeonhardt TylerLeonhardt merged commit 705f174 into PowerShell:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants