Update Travis to PowerShell Core 6.0.2 #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
changed the title
rkeithhill
reviewed
Jun 19, 2018
build/download.sh
Outdated
| bash <(curl -s https://raw.githubusercontent.com/PowerShell/PowerShell/master/tools/install-powershell.sh) |
There was a problem hiding this comment.
Don't we still want the shebang on the first line? And if we do that, then we don't need to invoke bash here - just curl. Then again, my *nix skills have atrophied over the years. Is there an advantage to doing it this way?
There was a problem hiding this comment.
I think we still need to invoke bash here because curl will just give you a string of the script - then you need to actually invoke it.
I can add the shebang :) alternatively... we could just delete this download.sh script and put that line in the travis.yml! I kinda like that better.
Thoughts?
There was a problem hiding this comment.
Simpler is usually better. I say go for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
download.shgiving us newer versions of PowerShellpowershell->pwshFixes #1370
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready