-
Notifications
You must be signed in to change notification settings - Fork 510
add temp task to build a v2 version of the extension & updates version of vscode-languageclient (WIP) #1350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!
@@ -97,19 +97,19 @@ export class NewFileOrProjectFeature implements IFeature { | |||
|
|||
if (!includeInstalledModules) { | |||
templates = | |||
[{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is brutal. Does TypeScript force this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah Typescript wasn't happy without those :/
# grab 2.0 PSRL bits | ||
Write-Host "`n### Grabbing 2.0 bits" | ||
Push-Location ..\PowerShellEditorServices | ||
git remote add patrick https://github.com/SeeminglyScience/PowerShellEditorServices.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporary until we merge the PSReadLine PR into the v2 branch, yeah?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Then we'll just checkout the v2 branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add temp task to build a v2 version of the extension & updates version of vscode vscode-languageclient