Skip to content

add temp task to build a v2 version of the extension & updates version of vscode-languageclient (WIP) #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2018

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Jun 6, 2018

Add temp task to build a v2 version of the extension & updates version of vscode vscode-languageclient

@TylerLeonhardt TylerLeonhardt changed the title add temp task to build a v2 version of the extension (WIP) add temp task to build a v2 version of the extension & updates version of vscode (WIP) Jun 7, 2018
@TylerLeonhardt TylerLeonhardt changed the title add temp task to build a v2 version of the extension & updates version of vscode (WIP) add temp task to build a v2 version of the extension & updates version of vscode-languageclient (WIP) Jun 7, 2018
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@@ -97,19 +97,19 @@ export class NewFileOrProjectFeature implements IFeature {

if (!includeInstalledModules) {
templates =
[{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is brutal. Does TypeScript force this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Typescript wasn't happy without those :/

# grab 2.0 PSRL bits
Write-Host "`n### Grabbing 2.0 bits"
Push-Location ..\PowerShellEditorServices
git remote add patrick https://github.com/SeeminglyScience/PowerShellEditorServices.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporary until we merge the PSReadLine PR into the v2 branch, yeah?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Then we'll just checkout the v2 branch

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt TylerLeonhardt merged commit 790e6e2 into PowerShell:master Jun 9, 2018
@TylerLeonhardt TylerLeonhardt deleted the v2-ci-build branch August 10, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants