SpecProcId - interactive var replacement supports only string type #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
changed the title
TylerLeonhardt
approved these changes
May 18, 2018
rkeithhill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1322
PR Summary
Fixes an issue some folks are seeing in VSCode 1.23.1 and I'm seeing in the insider's build (1.24.0) where using the "Attach to PS Host" debug config will error out after you have selected a process id to attach to. I believe this is due to VSCode getting more strict in the types they allow to be returned from a command evaluated inside a debug config e.g.:
We saw the very same issue with the command that pops UI to ask for script args.
I fixed a bug I ran into while testing this. If you have no documents open, attempt to attach to PS host process, cancel that and then attempt to "Launch Current File" there was an error appearing indicating property document was undefined (or something to that effect). Basically, where we attempt to get the current document, we assume the activeTextEditor is not undefined. Turns out that is a bad assumption.
Also cleaned up some of the error messages that appear when starting up a debug session now that notifications appear "shorter" until expanded.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is readyI'm waiting on confirmation of the fix from the folks seeing this issue in 1.23.1.