Skip to content

Add support for loading host profile scripts #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2016

Conversation

daviwil
Copy link
Contributor

@daviwil daviwil commented Mar 30, 2016

This change adds support for loading both host-specific and host-agnostic
profile scripts for both the current user and all users on the same
system. For VS Code, the profile names are Microsoft.VSCode_profile.ps1
and profile.ps1. The new 'enableProfileLoading' setting controls whether
profiles are loaded automatically when the language server starts up. For
now this setting is turned off by default.

Resolves #124.


This change is Reviewable

This change adds support for loading both host-specific and host-agnostic
profile scripts for both the current user and all users on the same
system.  For VS Code, the profile names are Microsoft.VSCode_profile.ps1
and profile.ps1.  The new 'enableProfileLoading' setting controls whether
profiles are loaded automatically when the language server starts up.  For
now this setting is turned off by default.

Resolves #124.
"/logLevel:Verbose",
"/hostName:\"Visual Studio Code Host\"",
"/hostProfileId:Microsoft.VSCode",
"/hostVersion:0.5.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debugger configuration is a little unfortunate since we have to update the version in 3 places in this file now. We'll need a version bump script in the near future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which "host" version is this? VSCode or PSES? If PSES, can't we read the version number from an assembly attribute via refection?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the VS Code extension's version. There will be a different property in the runspace for getting the PSES version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha.

@daviwil
Copy link
Contributor Author

daviwil commented Mar 30, 2016

Related pull request for PowerShell Editor Services:

PowerShell/PowerShellEditorServices#199

@daviwil daviwil merged commit e4f3dcc into master Mar 30, 2016
@daviwil daviwil deleted the daviwil/profile-support branch April 26, 2017 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants