Skip to content

Only check ipv4 addresses for port availlability during PSES startup #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2018
Merged

Only check ipv4 addresses for port availlability during PSES startup #1281

merged 1 commit into from
Apr 22, 2018

Conversation

rkeithhill
Copy link
Contributor

Fix #603 where system has ipv6 addresses disabled.

This is also more consistent with the PSES TCP listener which uses
[IPAddress]::Loopback as the IP address.

@rkeithhill
Only check ipv4 addresses for port availlability during PSES startup
239da92 
Fix #603 where system has ipv6 addresses disabled.

This is also more consistent with the PSES TCP listener which always
[IPAddress]::Loopback as the IP address.
TylerLeonhardt
TylerLeonhardt approved these changes Apr 22, 2018
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 glad we also got rid of that if statement too 😀

@rkeithhill
Copy link
Contributor Author

FWIW I believe the original issue was caused by $ipAddresses = [System.Net.Dns]::GetHostEntryAsync("localhost").Result.AddressList. We used to check only index 0 of the returned collection and on my system that is the IPv6 loopback address (::1). If IPv6 is disabled, you're hosed. Also, just because port 22222 is available on v6 doesn't mean it is available on v4 (and vice versa).

@TylerLeonhardt
Copy link
Member

interesting info. Thanks for sharing!

@rkeithhill rkeithhill merged commit 83b91cc into master Apr 22, 2018
@rkeithhill rkeithhill deleted the rkeithhill/pses-startup-fix branch April 22, 2018 00:10
@rjmholt rjmholt mentioned this pull request Apr 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkeithhill @TylerLeonhardt