Skip to content

Fix issue w/launch config not using the temp integrated console setting #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Fix issue w/launch config not using the temp integrated console setting #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/features/DebugSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,11 @@ export class DebugSessionFeature implements IFeature, DebugConfigurationProvider
config.cwd = currentDocument.fileName;
}

if (config.createTemporaryIntegratedConsole !== undefined) {
// If the createTemporaryIntegratedConsole field is not specified in the launch config, set the field using
// the value from the corresponding setting. Otherwise, the launch config value overrides the setting.
if (config.createTemporaryIntegratedConsole === undefined) {
config.createTemporaryIntegratedConsole = createNewIntegratedConsole;
} else {
createNewIntegratedConsole = config.createTemporaryIntegratedConsole;
}
}
Expand Down