Fix #1177 - Added function-advanced snippet #1182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
only renaming cmdlet and ex-cmdlet would fix this thing, or am I wrong? |
|
This is practically identical to the existing |
TylerLeonhardt
approved these changes
Feb 2, 2018
There was a problem hiding this comment.
LGTM. Thanks for contributing!
I opened an issue on vscode to support an array of prefixes so that we don't need two snippets:
microsoft/vscode#42838
but we wont block this PR on that.
rkeithhill
approved these changes
Feb 6, 2018
|
Merged! Congrats on your 1st contribution @Benny1007! |
|
microsoft/vscode#42838 is added, snippits can be merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function-advanced snippet based on the existing cmdlet snippet.
Leaves option to have more basic 'function' snippet based on the ISE 'function' snippet if required.
First PR, so grateful for further guidance.