Skip to content

add .Save() to FileContext API #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 3, 2018
Merged

add .Save() to FileContext API #1139

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47ccd39
add .Save() to FileContext API
TylerLeonhardt Dec 29, 2017
0198d8f
check for different OS's and also check if the file is dirty before s…
TylerLeonhardt Dec 29, 2017
2fdb3e8
macOS is case-insensitive
TylerLeonhardt Dec 29, 2017
a65f946
pull out find code into helper function
TylerLeonhardt Dec 29, 2017
cc04b7d
address Keith's feedback
TylerLeonhardt Jan 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion src/features/ExtensionCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,12 @@ export namespace CloseFileRequest {
'editor/closeFile');
}

export namespace SaveFileRequest {
export const type =
new RequestType<string, EditorOperationResponse, void, void>(
'editor/saveFile');
}

export namespace ShowErrorMessageRequest {
export const type =
new RequestType<string, EditorOperationResponse, void, void>(
Expand Down Expand Up @@ -239,14 +245,18 @@ export class ExtensionCommandsFeature implements IFeature {
NewFileRequest.type,
filePath => this.newFile());

this.languageClient.onRequest(
this.languageClient.onRequest(
OpenFileRequest.type,
filePath => this.openFile(filePath));

this.languageClient.onRequest(
CloseFileRequest.type,
filePath => this.closeFile(filePath));

this.languageClient.onRequest(
SaveFileRequest.type,
filePath => this.saveFile(filePath));

this.languageClient.onRequest(
ShowInformationMessageRequest.type,
message => this.showInformationMessage(message));
Expand Down Expand Up @@ -408,6 +418,36 @@ export class ExtensionCommandsFeature implements IFeature {
return promise;
}

private saveFile(filePath: string): Thenable<EditorOperationResponse> {

var promise: Thenable<EditorOperationResponse>;
Copy link
Contributor

@rkeithhill rkeithhill Dec 31, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another linter thing and something @daviwil espoused as well - favor the use of let over var. let is properly blocked scoped in JavaScript. I'm commenting on this one line about it but there are quite a few var usages in this PR that should be let.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed all occurrences in the file :)


// Make sure the file path is absolute
if (!path.win32.isAbsolute(filePath))
{
filePath = path.win32.resolve(
vscode.workspace.rootPath,
filePath);
}

// Normalize file path case for comparison
var normalizedFilePath = filePath.toLowerCase();

if (vscode.workspace.textDocuments.find(doc => doc.fileName.toLowerCase() == normalizedFilePath))
Copy link
Contributor

@rkeithhill rkeithhill Dec 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful here. On Linux, the file system is case-sensitive so this test could find the wrong file. Probably need to do a runtime check of the OS or file-system. I wonder if there is some function in node's OS or Path modules that could help?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good point. I actually grabbed that from:
https://github.com/PowerShell/vscode-powershell/blob/master/src/features/ExtensionCommands.ts#L393

So I'll update that as well. Perhaps we should still normalize on Windows?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows and I think macOS, right? Doesn't it also have a case-insensitive file system?

Copy link
Member Author

@TylerLeonhardt TylerLeonhardt Dec 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I didn't know macOS was case-insensitive! I'll fix the if-check.

{
promise =
vscode.workspace.openTextDocument(filePath)
.then(doc => doc.save())
.then(_ => EditorOperationResponse.Completed);
}
else
{
promise = Promise.resolve(EditorOperationResponse.Completed);
}

return promise;
}

private setSelection(details: SetSelectionRequestArguments): EditorOperationResponse {
vscode.window.activeTextEditor.selections = [
new vscode.Selection(
Expand Down