Minor bug fixes for 0.5.0 #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rkeithhill I'm not auto-resolving #55 with that commit, will wait for your change to the default launch config before I resolve it. |
This change causes the LanguageClient class to not be created on non-Windows OSes (specifically OS X and Linux). Previously this had not caused a major issue for users on OS X but it eventually became apparent that VS Code's default word-based completion engine did not work for OS X users because we were still registering our completion provider even though it was not able to execute on that OS.
This change adds a new 'useX86Host' setting for the language service which causes the 32-bit host to be launched in 64-bit Windows. Part of the solution for #55.
daviwil
force-pushed
the
daviwil/minor-fixes
branch
from
34af8bd to
b1083d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issues #55 and #106. Still looking into a couple more issues.