Update to use DebugConfigurationProvider #1062
Conversation
Fix #1046 Fix warning in status bar about ThemeColor This fix requires PSES PR 556 to eliminate one PSES cause of the debug adapter to crash. Also npm generated a package-lock.json file which, from what I've read, should be checked in. I haven't included it in this PR - yet. Thoughts? Also, I updated min VSCode version to 1.17.0. I'm not sure when the new DebugConfigurationProvider API was intro'd. I have tested with 1.17.2 and it works there so I'm reasonably confident it will work in 1.17.0. We might be able to reach back a bit further. We'd have to find out when this API was intro'd.
|
Hmm, set vscode engine min level to 1.16.0 and got this: Maybe we just stick with a minimum of VSCode |
rkeithhill
force-pushed
the
rkeithhill/update-dbg-protocol
branch
from
dc43a12 to
b325257
Compare
|
Yep, go ahead and add package-lock.json, it's new the new standard behavior in Node 8 I think. I suppose my only concern here is whether we ship an update later this week (I'd like to) and if this will work in VS Code 1.16.0. Have you tried loading the built extension in that version to see if it works? |
|
I bumped the version down to 1.16, pushed that but one of the builds failed. So I backed that change out. |
|
I'll add the package-lock.json file as soon as I get home tonight. |
Also update .gitattribtues to configure npm files to use LF since the newer version seems insistent about using LF. See npm/npm#17161
|
Done. |
|
For the record, it seems the API we need only exists in 1.16.0 in the vscode.proposed.d.ts typings file. In 1.17.0 the API appears in the vscode.d.ts file. |
|
I just tried your changes in 1.17.2, they work great! Thinking about merging this now, anything else you needed to do? |
|
I think this one is ready to go. |
|
Awesome, thanks a lot for fixing it! |
Fix #1046
Fix warning in status bar about ThemeColor
This fix requires PSES PR 556 to eliminate one PSES cause of the debug adapter to crash.
Also npm generated a package-lock.json file which, from what I've read, should be checked in. I haven't included it in this PR - yet. Thoughts?
Also, I updated min VSCode version to 1.17.0. I'm not sure when the new DebugConfigurationProvider API was intro'd. I have tested with 1.17.2 and it works there so I'm reasonably confident it will work in 1.17.0. We might be able to reach back a bit further. We'd have to find out when this API was intro'd.