-
Notifications
You must be signed in to change notification settings - Fork 510
Set-VSCodeHtmlContentView should allow passing stylesheets and JavaScript files as a parameter #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yep, passing stylesheets as a parameter is coming next! |
Hi Guys, |
That's awesome Kamil :) Yes, I'll be adding the ability to pass JavaScript paths too! Just needed to enable it in a fairly secure way (no dynamic loading of JavaSscript from files on disk). There's a way I can set it up to work with that content policy so that we get the best of both worlds. |
Thanks :) |
Yep, this will ultimately be possible through PSES "editor commands" but we need to make it possible to send them parameters first. VS Code allows you to invoke commands registered in the editor (like PSES editor commands) from within this HTML view, you just need to encode URIs in a certain way: https://code.visualstudio.com/docs/extensionAPI/vscode-api-commands#_links Not sure if there's a way to invoke them without having the URI inside of a link, though. |
Cool :)
you mean that we need to register a new vscode.command, maybe PowerShell.InvokeEditorCommand which accepts the desired command-name as a parameter and then invoke the command on the LanguageServer through the LanguageClient? |
This change adds new parameters to Set-VSCodeHtmlContentView which allow the user to specify JavaScriptPaths and StyleSheetPaths to include local JavaScript and CSS files into their HTML views. Part of the fix for PowerShell/vscode-powershell#910.
This change adds the client-side behavior for new parameters to Set-VSCodeHtmlContentView which allow the user to specify JavaScriptPaths and StyleSheetPaths to include local JavaScript and CSS files into their HTML views. Resolves PowerShell#910.
This change adds new parameters to Set-VSCodeHtmlContentView which allow the user to specify JavaScriptPaths and StyleSheetPaths to include local JavaScript and CSS files into their HTML views. Part of the fix for PowerShell/vscode-powershell#910.
This change adds new parameters to Set-VSCodeHtmlContentView which allow the user to specify JavaScriptPaths and StyleSheetPaths to include local JavaScript and CSS files into their HTML views. Part of the fix for PowerShell/vscode-powershell#910.
This change adds the client-side behavior for new parameters to Set-VSCodeHtmlContentView which allow the user to specify JavaScriptPaths and StyleSheetPaths to include local JavaScript and CSS files into their HTML views. Resolves #910.
It would be great if we could style our HTML with the new *-VSCodeHtml cmdlets available with v1.4.0. It could possibly be implemented by giving us access to use tags, or by passing in stylesheets to a parameter.
The text was updated successfully, but these errors were encountered: