Skip to content

Restarting PowerShell session doesn't retain PowerShell Core selection #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daviwil opened this issue May 31, 2017 · 8 comments · Fixed by #809
Closed

Restarting PowerShell session doesn't retain PowerShell Core selection #807

daviwil opened this issue May 31, 2017 · 8 comments · Fixed by #809
Labels
Issue-Bug A bug to squash.
Milestone
1.2.1

Comments

@daviwil
Copy link
Contributor

daviwil commented May 31, 2017

For some reason when I select one of the new PowerShell Core entries from the session menu, let the new session load, then try to reload it, it goes back to selecting the built-in Windows PowerShell install. I would expect it to reload the session that was selected most recently.
@daviwil daviwil added this to the 1.2.1 milestone May 31, 2017
@rkeithhill
Copy link
Contributor

Same thing happens when you switch to built-in x86. :-(

@daviwil
Copy link
Contributor Author

daviwil commented May 31, 2017

Weird... Not sure how that broke!

@daviwil
Copy link
Contributor Author

daviwil commented May 31, 2017

In other words, I don't think your changes caused it :)

@rkeithhill
Copy link
Contributor

rkeithhill commented May 31, 2017 •
edited
Loading

It's like you're a mind reader. :-p But that doesn't necessarily mean my change didn't break something. I hope not.

@daviwil
Copy link
Contributor Author

daviwil commented May 31, 2017

I'm pretty sure it didn't, the more likely culprit is the changes around adoption of the newer vscode-languageclient library, that broke other stuff too.

@daviwil
Copy link
Contributor Author

daviwil commented May 31, 2017

Ok, I'm wondering if this ever worked...

https://github.com/PowerShell/vscode-powershell/blob/master/src/session.ts#L713

@rkeithhill
Copy link
Contributor

Guess that should be passing in the current sessionConfiguration, eh?

@daviwil
Copy link
Contributor Author

daviwil commented May 31, 2017

Yep. I'm about to submit a PR

daviwil added a commit to daviwil/vscode-powershell that referenced this issue May 31, 2017
@daviwil
Restarting PowerShell session now retains previous configuration
7e6d7c0 
This change fixes PowerShell#807 which states that restarting the current
PowerShell session using the "Restart Current Session" command doesn't
retain the current session configuration if the user previously switched
their configuration using the session menu.  The fix is to change the
call to restartSession to use the current session configuration when
this command is invoked.
@daviwil daviwil mentioned this issue May 31, 2017
Merged
daviwil added a commit that referenced this issue May 31, 2017
@daviwil
Restarting PowerShell session now retains previous configuration
b5c0abe 
This change fixes #807 which states that restarting the current
PowerShell session using the "Restart Current Session" command doesn't
retain the current session configuration if the user previously switched
their configuration using the session menu.  The fix is to change the
call to restartSession to use the current session configuration when
this command is invoked.
daviwil added a commit that referenced this issue Jun 1, 2017
@daviwil
One more fix for session restarting issue #807
c590d8d 
This change fixes one remaining issue with restarting PowerShell
sessions that were started using the session menu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug A bug to squash.
Projects
None yet
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

Restarting PowerShell session now retains previous configuration daviwil/vscode-powershell
2 participants
@daviwil @rkeithhill