Skip to content

Change "Starting PowerShell" message when Integrated Console starts up #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kvprasoon opened this issue May 23, 2017 · 11 comments
Closed
Labels
Area-Extension Terminal Issue-Enhancement A feature request (enhancement).
Milestone

Comments

@kvprasoon
Copy link

Integrated terminal is awesome, especially when it is PowerShell.
But it always shows "Starting PowerShell..." even if is started.

image

We would like our awesome editor to its maximum perfection.

System Details

  • Operating system name and version: Windows 10 (10586.916)

  • VS Code version: 1.10.2

  • PowerShell extension version: 1.0.0

  • Output from $PSVersionTable: 5.0.10586.672

@daviwil
Copy link
Contributor

daviwil commented May 23, 2017

That's because "Starting PowerShell..." is output. If you type "Get-Process", the output will push it out of the screen. Are you asking for it to never be displayed?

@PowerSchill
Copy link
Contributor

He might be referring to #742

@daviwil
Copy link
Contributor

daviwil commented May 23, 2017

That's what I thought at first, but he's not using a Windows Insider build.

@rkeithhill
Copy link
Contributor

rkeithhill commented May 23, 2017

You can put Clear-Host in your C:\Users\<username>\Documents\WindowsPowerShell\Microsoft.VSCode_profile.ps1 and that will clear this message when the profile script is processed. That's what I do. :-)

@daviwil
Copy link
Contributor

daviwil commented May 23, 2017

I wonder if more people are annoyed by the message? I considered that when I added it, but I thought that maybe having it there was helpful to indicate that you're in the Integrated Console.

@rkeithhill
Copy link
Contributor

rkeithhill commented May 23, 2017

Maybe it's the transient nature of the message that might be a teensy bit confusing. Taking a page from the powershell.exe:
image
What if you modified the message to:

PowerShell Integrated Console <version #?>
PS C:\> 

For the default prompt, you might even make it:

PSIC C:\>

Or maybe that's going too far?

@daviwil
Copy link
Contributor

daviwil commented May 23, 2017

Yeah, I think that's the right way to do it.

@daviwil daviwil changed the title Integrated terminal [PowerShell] Change "Starting PowerShell" message when Integrated Console starts up May 23, 2017
@daviwil daviwil added Area-Extension Terminal Issue-Enhancement A feature request (enhancement). labels May 23, 2017
@daviwil daviwil added this to the 1.2.0 milestone May 23, 2017
@kvprasoon
Copy link
Author

or We can have the Starting PowerShell message in the Status bar, where we see icons of error and warning !!! (and clear it once started).

image

@rkeithhill
Copy link
Contributor

rkeithhill commented May 24, 2017

The status bar message already exists:
image
The "want", as @daviwil says above, is to provide a way to help folks know when they are in the PowerShell Integrated Console vs a normal PowerShell terminal. They look pretty close to the same.

@kvprasoon
Copy link
Author

kvprasoon commented May 24, 2017

@rkeithhill my bad, I didn't noticed it. Then I think that is more than sufficient and no need to have it in console ...

daviwil added a commit to daviwil/vscode-powershell that referenced this issue May 26, 2017
daviwil added a commit to daviwil/vscode-powershell that referenced this issue May 30, 2017
@kvprasoon
Copy link
Author

Thanks for addressing this, This is address elegantly in 1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extension Terminal Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

4 participants