Skip to content

Prompt written on Linux or macOS has black background #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daviwil opened this issue Mar 30, 2017 · 3 comments · Fixed by PowerShell/PowerShellEditorServices#548
Closed

Prompt written on Linux or macOS has black background #637

daviwil opened this issue Mar 30, 2017 · 3 comments · Fixed by PowerShell/PowerShellEditorServices#548
Labels
Area-Extension Terminal Issue-Bug A bug to squash.

Comments

@daviwil
Copy link
Contributor

daviwil commented Mar 30, 2017

Originally reported by @joeyaiello, and I've seen it too on macOS:

#594 (comment)

Need to keep using the existing Console.BackgroundColor instead of changing it to black.
@daviwil daviwil modified the milestones: Next Patch Update, Next Feature Update Mar 30, 2017
@Happycoil
Copy link

With VS Code 1.12.0 you can work around this issue by adding the following to settings.json:

"workbench.colorCustomizations": {
    "terminal.ansiBlack": "#1E1E1E"
}

This is for Dark+, replace 1E1E1E with the appropriate color for your theme.

@daviwil daviwil modified the milestones: April 2017, May 2017 May 8, 2017
@daviwil daviwil modified the milestones: May 2017, June 2017 Jun 1, 2017
@daviwil daviwil modified the milestones: June 2017, July 2017 Jul 11, 2017
@daviwil daviwil modified the milestones: 1.5.0, July 2017 Aug 22, 2017
daviwil added a commit to daviwil/PowerShellEditorServices that referenced this issue Aug 22, 2017
@daviwil
Use raw console bgcolor by default in IHostOutput.WriteOutput
d6a994d 
This change resolves PowerShell/vscode-powershell#637 which reports that
on Linux and macOS the input prompt is printed out with a black
background, overriding the console's default background color.  The
fix is to use a System.ConsoleColor of -1 as the default rather than
System.ConsoleColor.Black so that .NET's console library will not
override the console's background color.
@daviwil daviwil mentioned this issue Aug 22, 2017
Merged
daviwil added a commit to PowerShell/PowerShellEditorServices that referenced this issue Aug 22, 2017
@daviwil
Use raw console bgcolor by default in IHostOutput.WriteOutput
b536aff 
This change resolves PowerShell/vscode-powershell#637 which reports that
on Linux and macOS the input prompt is printed out with a black
background, overriding the console's default background color.  The
fix is to use a System.ConsoleColor of -1 as the default rather than
System.ConsoleColor.Black so that .NET's console library will not
override the console's background color.
@mklement0
Copy link
Contributor

Unfortunately, this is still broken as of v1.4.3 on macOS 10.13, shown here with the "Light+" color theme:

image

To spell out the workaround for white-background themes, courtesy of @Happycoil's tip:

   "workbench.colorCustomizations": {
      "terminal.ansiBlack": "#fff"
    }

@daviwil
Copy link
Contributor Author

daviwil commented Oct 23, 2017

The fix for this issue hasn't actually been shipped yet, hoping to get it out this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Extension Terminal Issue-Bug A bug to squash.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use raw console bgcolor by default in IHostOutput.WriteOutput daviwil/PowerShellEditorServices
3 participants
@daviwil @mklement0 @Happycoil